raulcd commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1698309336


##########
python/pyarrow/tests/test_cpp_internals.py:
##########
@@ -26,6 +31,10 @@ def inject_cpp_tests(ns):
     Inject C++ tests as Python functions into namespace `ns` (a dict).
     """
     for case in get_cpp_tests():
+        if np is None and ('numpy' in case.name or 'pandas' in case.name):
+            # Skip C++ tests that require pandas or numpy if numpy not present
+            continue

Review Comment:
   As those are not test items at that point I wasn't sure how to add the 
markers here. I ended up adding a `pytest_collection_modifyitems` on 
`conftest.py` to add the corresponding markers. Let me know if this approach 
makes sense to you.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to