felipecrv commented on code in PR #36559:
URL: https://github.com/apache/arrow/pull/36559#discussion_r1695635488
##########
cpp/src/arrow/flight/sql/client.h:
##########
@@ -364,25 +364,15 @@ class ARROW_FLIGHT_SQL_EXPORT FlightSqlClient {
Status Close();
protected:
Review Comment:
I want to create a wrapper/helper that can't live in the header (as private
method) but it needs to call `DoPut` and `DoGet`.
Additionally: given that these are just for testing and FlightClient is
injectable I think a level of indirection can be removed by mocking the
`FlightClient` instead of the `FlightSqlClient`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
