lidavidm commented on code in PR #36559:
URL: https://github.com/apache/arrow/pull/36559#discussion_r1696064911


##########
cpp/src/arrow/flight/sql/client.h:
##########
@@ -364,25 +364,15 @@ class ARROW_FLIGHT_SQL_EXPORT FlightSqlClient {
   Status Close();
 
  protected:

Review Comment:
   In C++ that requires declaring everything as `virtual`, though, and 
FlightClient wasn't really meant as an interface. (Perhaps that could be 
changed.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to