vibhatha commented on code in PR #43482:
URL: https://github.com/apache/arrow/pull/43482#discussion_r1697780025
##########
java/dataset/src/main/cpp/jni_wrapper.cc:
##########
@@ -368,28 +368,105 @@ std::shared_ptr<arrow::Buffer>
LoadArrowBufferFromByteBuffer(JNIEnv* env, jobjec
inline bool ParseBool(const std::string& value) { return value == "true" ?
true : false; }
+inline bool ParseChar(const std::string& value) {
+ if (value.size() != 1) {
+ JniThrow("Csv convert option " + value + " should be a char");
+ }
+ return value.at(0);
+}
+
/// \brief Construct FragmentScanOptions from config map
#ifdef ARROW_CSV
+
+bool setCsvConvertOptions(arrow::csv::ConvertOptions& options, const
std::string& key,
Review Comment:
And probably, capitalize the first letter of the following method names as
well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
