jinchengchenghh commented on code in PR #43482:
URL: https://github.com/apache/arrow/pull/43482#discussion_r1697918189


##########
java/dataset/src/test/java/org/apache/arrow/dataset/TestFragmentScanOptions.java:
##########
@@ -165,4 +165,44 @@ public void testCsvConvertOptionsNoOption() throws 
Exception {
       assertEquals(3, rowCount);
     }
   }
+

Review Comment:
   Then we will need a lot of tests to check whether all the options are 
properly used. Do you think we should do that? Now I only add test to test one 
of CsvxxxOptions are properly used. @lidavidm @vibhatha 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to