sunby commented on code in PR #43485:
URL: https://github.com/apache/arrow/pull/43485#discussion_r1697905167
##########
cpp/src/arrow/array/concatenate.cc:
##########
@@ -565,10 +565,25 @@ class ConcatenateImpl {
}
Status Visit(const StructType& s) {
+ std::shared_ptr<StructType> suggested = nullptr;
Review Comment:
>
Thanks for this correction. So we only need to return fields that fail to do
the concatenation right? I originally thought that returning normal fields
would be more user-friendly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
