felipecrv commented on code in PR #43485:
URL: https://github.com/apache/arrow/pull/43485#discussion_r1698897510
##########
cpp/src/arrow/array/concatenate.cc:
##########
@@ -686,6 +703,7 @@ class ConcatenateImpl {
RETURN_NOT_OK(ConcatenateImpl(child_data, pool_)
.Concatenate(&out_->child_data[i],
/*hints=*/nullptr));
}
+
Review Comment:
```suggestion
```
##########
cpp/src/arrow/array/concatenate_test.cc:
##########
@@ -760,6 +760,24 @@ TEST_F(ConcatenateTest, OffsetOverflow) {
pool, &suggested_cast)
.status());
ASSERT_TRUE(suggested_cast->Equals(LargeVersionOfType(list_view_ty)));
+
+ auto struct_ty = struct_({field("a", int32()), field("b", list(utf8()))});
+ auto fake_long_struct = ArrayFromJSON(struct_ty, "[[0, [\"Hello\"]]]");
+ std::dynamic_pointer_cast<StructArray>(fake_long_struct)
Review Comment:
Use `internal::checked_pointer_cast<>(..)` from `arrow/util/checked_cast.h`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
