alamb commented on code in PR #6187:
URL: https://github.com/apache/arrow-rs/pull/6187#discussion_r1702708413
##########
parquet/src/arrow/arrow_reader/statistics.rs:
##########
@@ -1008,23 +1003,22 @@ macro_rules! get_data_page_statistics {
}
Ok(Arc::new(builder.finish()))
},
- Some(DataType::Null) |
- Some(DataType::Duration(_)) |
- Some(DataType::Interval(_)) |
- Some(DataType::List(_)) |
- Some(DataType::ListView(_)) |
- Some(DataType::FixedSizeList(_, _)) |
- Some(DataType::LargeList(_)) |
- Some(DataType::LargeListView(_)) |
- Some(DataType::Struct(_)) |
- Some(DataType::Union(_, _)) |
- Some(DataType::Map(_, _)) |
- Some(DataType::RunEndEncoded(_, _)) => {
+ DataType::Null |
+ DataType::Duration(_) |
+ DataType::Interval(_) |
+ DataType::List(_) |
+ DataType::ListView(_) |
+ DataType::FixedSizeList(_, _) |
+ DataType::LargeList(_) |
+ DataType::LargeListView(_) |
+ DataType::Struct(_) |
+ DataType::Union(_, _) |
+ DataType::Map(_, _) |
+ DataType::RunEndEncoded(_, _) => {
let len = $iterator.count();
// don't know how to extract statistics, so return a null
array
- Ok(new_null_array($data_type.unwrap(), len))
+ Ok(new_null_array($data_type, len))
},
- None => unimplemented!() // not sure how to handle this
Review Comment:
The point of this PR is to remove this line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
