etseidl commented on code in PR #43428:
URL: https://github.com/apache/arrow/pull/43428#discussion_r1702806750
##########
cpp/src/parquet/metadata.h:
##########
@@ -146,7 +146,12 @@ class PARQUET_EXPORT ColumnChunkMetaData {
bool Equals(const ColumnChunkMetaData& other) const;
- // column chunk
+ // Byte offset of `ColumnMetaData` in `file_path()`.
+ //
+ // Note that the meaning of this field has been inconsistent between
implementations
+ // so its use has since been deprecated in the Parquet specification. Moder
Review Comment:
```suggestion
// so its use has since been deprecated in the Parquet specification.
Modern
```
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1536,10 +1536,11 @@ class
ColumnChunkMetaDataBuilder::ColumnChunkMetaDataBuilderImpl {
const std::shared_ptr<Encryptor>& encryptor) {
if (dictionary_page_offset > 0) {
column_chunk_->meta_data.__set_dictionary_page_offset(dictionary_page_offset);
- column_chunk_->__set_file_offset(dictionary_page_offset +
compressed_size);
- } else {
- column_chunk_->__set_file_offset(data_page_offset + compressed_size);
}
+ // https://github.com/apache/parquet-format/pull/440
+ // The `file_offset` field is deprecated and should be set to 0 for writer
+ // if the column chunk has not been written outsidethe footer.
Review Comment:
```suggestion
// if the column chunk has not been written outside the footer.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
