mapleFU commented on code in PR #43428:
URL: https://github.com/apache/arrow/pull/43428#discussion_r1702807473
##########
cpp/src/parquet/metadata.cc:
##########
@@ -1536,10 +1536,11 @@ class
ColumnChunkMetaDataBuilder::ColumnChunkMetaDataBuilderImpl {
const std::shared_ptr<Encryptor>& encryptor) {
if (dictionary_page_offset > 0) {
column_chunk_->meta_data.__set_dictionary_page_offset(dictionary_page_offset);
- column_chunk_->__set_file_offset(dictionary_page_offset +
compressed_size);
- } else {
- column_chunk_->__set_file_offset(data_page_offset + compressed_size);
}
+ // https://github.com/apache/parquet-format/pull/440
+ // The `file_offset` field is deprecated and should be set to 0 for writer
+ // if the column chunk has not been written outsidethe footer.
Review Comment:
this is removed lol
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
