EnricoMi commented on code in PR #43537:
URL: https://github.com/apache/arrow/pull/43537#discussion_r1702857842
##########
python/pyarrow/_flight.pyx:
##########
@@ -736,6 +743,12 @@ cdef class FlightEndpoint(_Weakrefable):
CLocation.Parse(tobytes(location)).Value(&c_location))
self.endpoint.locations.push_back(c_location)
+ if expiration_time is not None:
+ self.endpoint.expiration_time = time_point(
+ microseconds(expiration_time.cast(timestamp("us")).value))
Review Comment:
I'd prefer nanoseconds as well, but that did not work on macOS:
```
/Users/runner/work/arrow/arrow/build/python/build/temp.macosx-10.9-universal2-cpython-311/_flight.cpp:31893:102:
error: no matching conversion for functional-style cast from
'std::chrono::nanoseconds' (aka 'duration<long long, ratio<1LL,
1000000000LL>>') to 'std::chrono::system_clock::time_point' (aka
'time_point<std::chrono::system_clock>')
__pyx_v_self->endpoint.expiration_time =
((std::optional<std::chrono::system_clock::time_point>
)std::chrono::system_clock::time_point(std::chrono::nanoseconds(__pyx_t_12)));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
https://github.com/EnricoMi/arrow/actions/runs/10083176212/job/27879168275#step:8:3720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
