pitrou commented on code in PR #43537:
URL: https://github.com/apache/arrow/pull/43537#discussion_r1705543355
##########
python/pyarrow/_flight.pyx:
##########
@@ -746,6 +759,24 @@ cdef class FlightEndpoint(_Weakrefable):
return [Location.wrap(location)
for location in self.endpoint.locations]
+ @property
+ def expiration_time(self):
Review Comment:
Can you add docstrings for these new properties?
##########
python/pyarrow/_flight.pyx:
##########
@@ -855,10 +888,14 @@ cdef class FlightInfo(_Weakrefable):
the descriptor for this flight.
endpoints : list of FlightEndpoint
a list of endpoints where this flight is available.
- total_records : int
- the total records in this flight, or -1 if unknown
- total_bytes : int
- the total bytes in this flight, or -1 if unknown
+ total_records : int optional, default -1
+ the total records in this flight, or -1 if unknown.
+ total_bytes : int optional, default -1
+ the total bytes in this flight, or -1 if unknown.
Review Comment:
`None` would be a preferrable default for a Python API, IMHO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
