alamb commented on code in PR #6148:
URL: https://github.com/apache/arrow-rs/pull/6148#discussion_r1705629300
##########
object_store/src/client/mod.rs:
##########
@@ -541,6 +578,10 @@ impl ClientOptions {
builder = builder.proxy(proxy);
}
+ for certificate in &self.user_ca_certificates {
+ builder = builder.add_root_certificate(certificate.0.clone());
Review Comment:
I am not sure what your previous versions of this PR used (as you seem to
have rebased and force pushed rather than pushing new commits) so I am sorry if
this is opposite of what @tustvold said before
It seems to me that we should follow the same convention as the `builder`
and use `root_certificates` unless there is some reason to go with different
terminology
Is there a different reason?
##########
object_store/src/client/mod.rs:
##########
@@ -167,10 +167,40 @@ impl FromStr for ClientConfigKey {
}
}
+/// Represents a CA certificate provided by the user.
+#[derive(Debug, Clone)]
+pub struct UserCA(reqwest::tls::Certificate);
Review Comment:
Why is this called a `CA`? Doesn't that normally imply a Certificate
Authority.
Reqwest just calls it a certificate
https://docs.rs/reqwest/latest/reqwest/struct.ClientBuilder.html#method.add_root_certificate
So I suggest:
```rust
pub struct Certificate(reqwest::tls::Certificate)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
