ByteBaker commented on code in PR #6148:
URL: https://github.com/apache/arrow-rs/pull/6148#discussion_r1710147709
##########
object_store/src/client/mod.rs:
##########
@@ -167,10 +167,40 @@ impl FromStr for ClientConfigKey {
}
}
+/// Represents a CA certificate provided by the user.
+#[derive(Debug, Clone)]
+pub struct UserCA(reqwest::tls::Certificate);
Review Comment:
This was originally called `UserCertificate`, but as @tustvold rightly
pointed out, it wasn't clear whether it was a client certificate (mTLS) or
server certificate, so I changed it.
But yes, I agree with you that `CA` is just even more misleading (in
addition to being incorrect). I could switch to `Certificate` as you've
suggested above, but I think I need a consensus here between you and @tustvold
about the name.
Once confirmed, I'll change it to `Certificate`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
