kou commented on code in PR #43586:
URL: https://github.com/apache/arrow/pull/43586#discussion_r1706382980
##########
dev/archery/archery/docker/cli.py:
##########
@@ -47,18 +47,24 @@ def _execute(self, *args, **kwargs):
help="Specify Arrow source directory.")
@click.option('--dry-run/--execute', default=False,
help="Display the docker commands instead of executing them.")
+@click.option('--using-legacy-docker-compose', default=False, is_flag=True,
+ envvar='ARCHERY_USE_LEGACY_DOCKER_COMPOSE',
+ help="Use legacy docker-compose utility instead of the built-in "
+ "`docker compose` subcommand. This may be necessary if the "
+ "Docker client is too old for some options.")
@click.option('--using-docker-cli', default=False, is_flag=True,
envvar='ARCHERY_USE_DOCKER_CLI',
help="Use docker CLI directly for building instead of calling "
- "docker-compose. This may help to reuse cached layers.")
+ "`docker compose`. This may help to reuse cached layers.")
Review Comment:
Can we remove this option?
##########
dev/tasks/tasks.yml:
##########
@@ -1110,9 +1110,8 @@ tasks:
template: docker-tests/github.linux.yml
params:
env:
- ARCHERY_USE_DOCKER_CLI: 0
UBUNTU: 20.04
- flags: -e ARROW_SKYHOOK=ON
+ flags: -e ARROW_SKYHOOK=ON -e ARROW_AZURE=OFF -e ARROW_GCS=OFF -e
ARROW_S3=OFF -e ARROW_GANDIVA=OFF
Review Comment:
How about using `>-` and sort them?
```suggestion
flags: >-
-e ARROW_AZURE=OFF
-e ARROW_GANDIVA=OFF
-e ARROW_GCS=OFF
-e ARROW_S3=OFF
-e ARROW_SKYHOOK=ON
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
