pitrou commented on code in PR #43586:
URL: https://github.com/apache/arrow/pull/43586#discussion_r1706755189
##########
dev/archery/archery/docker/cli.py:
##########
@@ -47,18 +47,24 @@ def _execute(self, *args, **kwargs):
help="Specify Arrow source directory.")
@click.option('--dry-run/--execute', default=False,
help="Display the docker commands instead of executing them.")
+@click.option('--using-legacy-docker-compose', default=False, is_flag=True,
+ envvar='ARCHERY_USE_LEGACY_DOCKER_COMPOSE',
+ help="Use legacy docker-compose utility instead of the built-in "
+ "`docker compose` subcommand. This may be necessary if the "
+ "Docker client is too old for some options.")
@click.option('--using-docker-cli', default=False, is_flag=True,
envvar='ARCHERY_USE_DOCKER_CLI',
help="Use docker CLI directly for building instead of calling "
- "docker-compose. This may help to reuse cached layers.")
+ "`docker compose`. This may help to reuse cached layers.")
Review Comment:
Well, apparently it's necessary for Windows wheels:
https://github.com/ursacomputing/crossbow/actions/runs/10269082430/job/28413695620
```
#6 [python-wheel-windows-test 2/5] RUN setx path "%path%;C:\Program
Files\Git\usr\bin"
failed to solve: process "cmd /S /C setx path \"%path%;C:\\Program
Files\\Git\\usr\\bin\"" did not complete successfully: buildkit executor not
implemented for windows
#6 ERROR: process "cmd /S /C setx path \"%path%;C:\\Program
Files\\Git\\usr\\bin\"" did not complete successfully: buildkit executor not
implemented for windows
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
