pitrou commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1708888976
##########
python/pyarrow/tests/test_types.py:
##########
@@ -1263,17 +1266,20 @@ def test_field_modified_copies():
def test_is_integer_value():
assert pa.types.is_integer_value(1)
- assert pa.types.is_integer_value(np.int64(1))
+ if np is not None:
+ assert pa.types.is_integer_value(np.int64(1))
assert not pa.types.is_integer_value('1')
[email protected]
Review Comment:
Can we just apply the same principle here and below (guard NumPy-specific
checks with `if np is not None` instead of skipping the whole test if NumPy is
absent)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
