raulcd commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1731286269
##########
python/pyarrow/tests/test_scalars.py:
##########
@@ -102,6 +100,37 @@ def test_basics(value, ty, klass, pickle_module):
assert wr() is None
[email protected]
+def test_basics_np_required(pickle_module):
+ value, ty, klass = np.float16(1.0), pa.float16(), pa.HalfFloatScalar
+ s = pa.scalar(value, type=ty)
Review Comment:
I am not sure I understand how the test above is testing `HalfFloatScalar`
if I remove from the parametrization:
`(np.float16(1.0), pa.float16(), pa.HalfFloatScalar),`
I am trying to remove `np` from parametrize in order to avoid collection
failures.
@jorisvandenbossche are you suggesting I can just remove `(np.float16(1.0),
pa.float16(), pa.HalfFloatScalar),` as this one is already covered on the rest
of the tests and avoid adding a new test for this case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
