joellubi commented on code in PR #43641:
URL: https://github.com/apache/arrow/pull/43641#discussion_r1713497484
##########
go/parquet/pqarrow/schema.go:
##########
@@ -249,7 +249,7 @@ func structToNode(typ *arrow.StructType, name string,
nullable bool, props *parq
return schema.NewGroupNode(name, repFromNullable(nullable), children,
-1)
}
-func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties, arrprops ArrowWriterProperties) (schema.Node, error)
{
+func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties, arrprops ArrowWriterProperties, customLogicalType
*LogicalType) (schema.Node, error) {
Review Comment:
Maybe instead of adding a function parameter here we could optionally
specify the logical type in
[ColumnProperties](https://github.com/apache/arrow/blob/ee86db57bb771dbdb5f2fca5890854f27e6aa964/go/parquet/writer_properties.go#L54)
which can be accessed per-column through the existing `props` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
