datbth commented on code in PR #43641:
URL: https://github.com/apache/arrow/pull/43641#discussion_r1713553080
##########
go/parquet/pqarrow/schema.go:
##########
@@ -249,7 +249,7 @@ func structToNode(typ *arrow.StructType, name string,
nullable bool, props *parq
return schema.NewGroupNode(name, repFromNullable(nullable), children,
-1)
}
-func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties, arrprops ArrowWriterProperties) (schema.Node, error)
{
+func fieldToNode(name string, field arrow.Field, props
*parquet.WriterProperties, arrprops ArrowWriterProperties, customLogicalType
*LogicalType) (schema.Node, error) {
Review Comment:
I think that would be confusing for the `parquet` APIs.
When writing parquet files, logical types should be specified right when
creating the parquet schema.
This extra parameter is only relevant for `pqarrow` only so I think it
should be within the scope of `pqarrow`.
Perhaps I can pass it down via `pqarrow.ArrowWriterProperties` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
