kou commented on code in PR #43671:
URL: https://github.com/apache/arrow/pull/43671#discussion_r1716117766
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-python-313-freethreading-test.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ args:
+ base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
+ shm_size: *shm-size
+ environment:
+ <<: [*common, *ccache]
+ # Bundled build of OpenTelemetry needs a git client
+ ARROW_WITH_OPENTELEMETRY: "OFF"
+ PYARROW_VERSION: ${PYARROW_VERSION:-}
+ volumes: *ubuntu-volumes
+ command: >
+ /bin/bash -c "
+ /arrow/ci/scripts/cpp_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_build.sh /arrow /build &&
+ /arrow/ci/scripts/python_test.sh /arrow"
Review Comment:
```suggestion
command: *python-command
```
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
Review Comment:
Could you remove `-test` suffix like we did for `ubuntu-python`?
```suggestion
ubuntu-python-313-freethreading:
```
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-python-313-freethreading-test.dockerfile
Review Comment:
```suggestion
dockerfile: ci/docker/linux-apt-python-313-freethreading.dockerfile
```
##########
ci/docker/linux-apt-python-313-freethreading-test.dockerfile:
##########
Review Comment:
Could you remove `-test` from filename?
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-python-313-freethreading-test.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
Review Comment:
```suggestion
- ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading
```
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ build:
+ context: .
+ dockerfile: ci/docker/linux-apt-python-313-freethreading-test.dockerfile
+ cache_from:
+ - ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
+ args:
+ base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cpp
+ shm_size: *shm-size
+ environment:
+ <<: [*common, *ccache]
+ # Bundled build of OpenTelemetry needs a git client
+ ARROW_WITH_OPENTELEMETRY: "OFF"
+ PYARROW_VERSION: ${PYARROW_VERSION:-}
Review Comment:
Do we need this?
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
+ image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading-test
Review Comment:
```suggestion
image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-313-freethreading
```
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
+ # UBUNTU: 20.04, 22.04
Review Comment:
```suggestion
# UBUNTU: 20.04, 22.04, 24.04
```
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
+ # Parameters:
+ # ARCH: amd64, arm64v8, ...
+ # PYARROW_VERSION: The test target pyarrow version such as "3.0.0"
Review Comment:
Do we need this?
##########
docker-compose.yml:
##########
@@ -1086,6 +1087,38 @@ services:
/arrow/ci/scripts/cpp_build.sh /arrow /build &&
/arrow/ci/scripts/python_sdist_test.sh /arrow"
+ ############################ Python free-threading ##########################
+
+ ubuntu-python-313-freethreading-test:
+ # Usage:
+ # docker-compose build ubuntu-cpp
+ # docker-compose build ubuntu-python-313-freethreading-test
+ # docker-compose run --rm ubuntu-python-313-freethreading-test
Review Comment:
```suggestion
# docker-compose build ubuntu-python-313-freethreading
# docker-compose run --rm ubuntu-python-313-freethreading
```
##########
dev/tasks/tasks.yml:
##########
@@ -1254,6 +1254,14 @@ tasks:
PYTHON: "3.10"
image: conda-python-cython2
+ test-ubuntu-22.04-python-313-freethreading:
+ ci: github
+ template: docker-tests/github.linux.yml
+ params:
+ env:
+ UBUNTU: 22.04
+ image: ubuntu-python-313-freethreading-test
Review Comment:
```suggestion
image: ubuntu-python-313-freethreading
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
