lysnikolaou commented on code in PR #43671: URL: https://github.com/apache/arrow/pull/43671#discussion_r1718206926
########## python/CMakeLists.txt: ########## @@ -21,6 +21,8 @@ cmake_minimum_required(VERSION 3.16) project(pyarrow) +set(CMAKE_NO_SYSTEM_FROM_IMPORTED ON) Review Comment: Okay, this was a hard one. CMake used to add Python include directories with `-isystem`, which led to some Python-internal includes to resolve to normal 3.13 includes, instead of 3.13-free-threading, which in turn meants that `Py_GIL_DISABLED` was not set. Setting this flag uses `-I` instead. I verified manually that the only include directories here are python-specific (Python & NumPy include directories), so this shouldn't change too much. I couldn't find how I can change this in a more granular way. If someone knows that, help would be really appreaciated! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
