kou commented on code in PR #43671: URL: https://github.com/apache/arrow/pull/43671#discussion_r1719173490
########## python/CMakeLists.txt: ########## @@ -21,6 +21,8 @@ cmake_minimum_required(VERSION 3.16) project(pyarrow) +set(CMAKE_NO_SYSTEM_FROM_IMPORTED ON) Review Comment: Can we use the `SYSTEM` target property https://cmake.org/cmake/help/latest/prop_tgt/SYSTEM.html instead of this to limit the impact? ```diff diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt index 5d5eeaf815..c19820c074 100644 --- a/python/CMakeLists.txt +++ b/python/CMakeLists.txt @@ -258,6 +258,8 @@ set(EXECUTABLE_OUTPUT_PATH "${BUILD_OUTPUT_ROOT_DIRECTORY}") find_package(Python3Alt REQUIRED) message(STATUS "Found NumPy version: ${Python3_NumPy_VERSION}") message(STATUS "NumPy include dir: ${NUMPY_INCLUDE_DIRS}") +# TODO: Describe why we need this +set_target_properties(Python3::Python PROPERTIES SYSTEM FALSE) include(UseCython) message(STATUS "Found Cython version: ${CYTHON_VERSION}") ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
