paleolimbot opened a new pull request, #2081: URL: https://github.com/apache/arrow-adbc/pull/2081
This PR removes fmt as a required component of a driver based on the driver framework. This is so that we can eliminate `c/driver/common/driver_base.h` in favour of the much better `c/driver/framework`. The fmt library is great and easy to use and we should absolutely use it in our own drivers; however, I don't know of any libraries that would want to export an ADBC driver that don't already have a scheme for error generation (e.g., Arrow's Status or GDAL's `cpl_error.h`). I think I've done this in such a way that we keep all the benefits for our own drivers but drop the requirement for all users. This PR leans in to the `Status/Result`. I take back everything I ever said about it...it's awesome and we should keep it (closes #1663). I didn't do it here because it would make the PR bigger, but I would like to do the same thing for nanoarrow (i.e., remove it as a requirement for framework-based drivers). The initial targets for libraries that might want to emebed a driver already have their own way to generate Arrow schemas, arrays, and array streams, and have expressed general disinterest at a nanoarrow dependency (e.g., GDAL, Arrow C++). Pragmatically, it might also tie a library that already uses nanoarrow to a specific nanoarrow version (since there is no guarantee of stability yet). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
