paleolimbot commented on code in PR #2081: URL: https://github.com/apache/arrow-adbc/pull/2081#discussion_r1723263181
########## c/driver/framework/status.h: ########## @@ -20,13 +20,17 @@ #include <cassert> #include <cstring> #include <memory> +#include <sstream> #include <string> #include <utility> #include <variant> #include <vector> -#include <arrow-adbc/adbc.h> +#if defined(ADBC_FRAMEWORK_USE_FMT) Review Comment: Keep forever, I think (definitely the way to go for drivers in the ADBC repo). Maybe cleaner as different header instead of embedding it here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
