zanmato1984 commented on code in PR #43720: URL: https://github.com/apache/arrow/pull/43720#discussion_r1721486888
########## cpp/src/arrow/compute/kernels/aggregate_basic-inl.cc: ########## Review Comment: Shall we make it a header file? I think it has the same effect as an include-only cc file. ########## cpp/src/arrow/compute/kernels/aggregate_basic.cc: ########## @@ -15,15 +15,29 @@ // specific language governing permissions and limitations // under the License. +#include <cassert> +#include <cmath> +#include <memory> +#include <type_traits> +#include <utility> + #include "arrow/compute/api_aggregate.h" #include "arrow/compute/kernels/aggregate_basic_internal.h" #include "arrow/compute/kernels/aggregate_internal.h" +#include "arrow/compute/kernels/codegen_internal.h" #include "arrow/compute/kernels/common_internal.h" #include "arrow/compute/kernels/util_internal.h" +#include "arrow/type.h" +#include "arrow/type_traits.h" +#include "arrow/util/align_util.h" +#include "arrow/util/bit_block_counter.h" #include "arrow/util/cpu_info.h" +#include "arrow/util/decimal.h" #include "arrow/util/hashing.h" -#include <memory> +// Include templated definitions for aggregate kernels that must compiled here +// with the SIMD level configured for this compilation unit in the build. +#include "arrow/compute/kernels/aggregate_basic-inl.cc" // NOLINT Review Comment: Yes it is short for "inline". I think "-inl" (or similarly ".inl") is more commonly seen in other cpp projects than "_inline". Some examples: https://github.com/google/googletest/blob/main/googletest/src/gtest-internal-inl.h https://github.com/facebook/folly/blob/main/folly/futures/Future-inl.h https://github.com/boostorg/thread/blob/master/test/util.inl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
