felipecrv commented on code in PR #43720:
URL: https://github.com/apache/arrow/pull/43720#discussion_r1721919477
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -272,26 +286,29 @@ void AddCountDistinctKernels(ScalarAggregateFunction*
func) {
// Sum implementation
template <typename ArrowType>
-struct SumImplDefault : public SumImpl<ArrowType, SimdLevel::NONE> {
+struct SumImplNative : public SumImpl<ArrowType, SimdLevel::NONE> {
Review Comment:
I wanted a better word than "Default" and came up with "Native". "Basic" or
"Naive" don't fully capture it. "Native" is bad also, I agree. Any suggestions
or should I leave as "Default"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
