paleolimbot commented on code in PR #43196:
URL: https://github.com/apache/arrow/pull/43196#discussion_r1722114973


##########
cpp/src/parquet/types.h:
##########
@@ -166,6 +167,14 @@ class PARQUET_EXPORT LogicalType {
     enum unit { UNKNOWN = 0, MILLIS = 1, MICROS, NANOS };
   };
 
+  struct GeometryEncoding {

Review Comment:
   This follows the pattern of the other enums in types.h, which I am guessing 
would be enum classes if they were written today (maybe dating from a C++11 or 
pre-C++11 era?).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to