paleolimbot commented on code in PR #43196:
URL: https://github.com/apache/arrow/pull/43196#discussion_r1722126641
##########
cpp/src/parquet/types.cc:
##########
@@ -463,6 +463,31 @@ std::shared_ptr<const LogicalType> LogicalType::FromThrift(
return UUIDLogicalType::Make();
} else if (type.__isset.FLOAT16) {
return Float16LogicalType::Make();
+ } else if (type.__isset.GEOMETRY) {
+ std::string crs;
+ if (type.GEOMETRY.__isset.crs) {
+ crs = type.GEOMETRY.crs;
+ }
+
+ LogicalType::GeometryEdges::edges edges =
LogicalType::GeometryEdges::UNKNOWN;
+ if (type.GEOMETRY.edges == format::Edges::PLANAR) {
+ edges = LogicalType::GeometryEdges::PLANAR;
+ } else if (type.GEOMETRY.edges == format::Edges::SPHERICAL) {
+ edges = LogicalType::GeometryEdges::SPHERICAL;
+ }
+
+ LogicalType::GeometryEncoding::geometry_encoding encoding =
+ LogicalType::GeometryEncoding::UNKNOWN;
+ if (type.GEOMETRY.encoding == format::GeometryEncoding::WKB) {
+ encoding = LogicalType::GeometryEncoding::WKB;
+ }
+
+ std::string metadata;
Review Comment:
I believe that both string and binary come through C++ thrift as
`std::string`. Happy to have this be whatever but I think `std::string` is
consistent with our plans for its contents (JSON?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
