alamb commented on code in PR #6275:
URL: https://github.com/apache/arrow-rs/pull/6275#discussion_r1722375368
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -75,10 +75,12 @@ use super::ByteArrayType;
/// 0 31 63 95 127
/// ```
///
-/// * Strings with length <= 12 are stored directly in the view.
+/// * Strings with length <= 12 are stored directly in the view. See
Review Comment:
I think it will help to add pointers to common functions to manipulate the
views
##########
arrow/src/array/mod.rs:
##########
@@ -25,7 +25,7 @@ pub use arrow_array::cast::*;
pub use arrow_array::iterator::*;
pub use arrow_array::*;
pub use arrow_data::{
- layout, ArrayData, ArrayDataBuilder, ArrayDataRef, BufferSpec,
DataTypeLayout,
+ layout, ArrayData, ArrayDataBuilder, ArrayDataRef, BufferSpec, ByteView,
DataTypeLayout,
Review Comment:
this is the only code change in this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
