wiedld commented on code in PR #6275:
URL: https://github.com/apache/arrow-rs/pull/6275#discussion_r1722514463
##########
arrow-array/src/array/byte_view_array.rs:
##########
@@ -262,6 +266,7 @@ impl<T: ByteViewType + ?Sized> GenericByteViewArray<T> {
}
/// Returns the element at index `i`
+ ///
/// # Safety
/// Caller is responsible for ensuring that the index is within the bounds
of the array
pub unsafe fn value_unchecked(&self, idx: usize) -> &T::Native {
Review Comment:
It appears that the unsafe code in GenericByteViewArray is to avoid bounds
checking. Is this correct?
(I ask because it percolates into the [unsafe code in this datafusion
pr](https://github.com/apache/datafusion/pull/12044/files).)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
