etseidl commented on PR #6297: URL: https://github.com/apache/arrow-rs/pull/6297#issuecomment-2307885503
I must have hallucinated last night...turns out `copy_from_slice` actually is a bit faster for the long arrays. Master vs https://github.com/apache/arrow-rs/pull/6297/commits/1a1e967c4704fd5d67ccc5054d4673805a994656 <details> ``` group pad_loop pad_nulls_slice ----- -------- --------------- arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Decimal128Array/byte_stream_split encoded, optional, half NULLs 1.52 558.3±4.21µs ? ?/sec 1.00 367.8±3.17µs ? ?/sec arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Decimal128Array/plain encoded, optional, half NULLs 1.85 422.5±4.04µs ? ?/sec 1.00 228.8±3.73µs ? ?/sec arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/byte_stream_split encoded, optional, half NULLs 1.07 119.9±0.74µs ? ?/sec 1.00 112.3±1.55µs ? ?/sec arrow_array_reader/FIXED_LEN_BYTE_ARRAY/Float16Array/plain encoded, optional, half NULLs 1.16 105.7±1.24µs ? ?/sec 1.00 91.3±0.85µs ? ?/sec arrow_array_reader/FixedLenByteArray(16)/byte_stream_split encoded, optional, half NULLs 1.69 440.0±1.65µs ? ?/sec 1.00 259.7±2.18µs ? ?/sec arrow_array_reader/FixedLenByteArray(16)/plain encoded, optional, half NULLs 2.36 297.8±3.19µs ? ?/sec 1.00 126.3±1.59µs ? ?/sec arrow_array_reader/FixedLenByteArray(2)/byte_stream_split encoded, optional, half NULLs 1.20 108.4±4.14µs ? ?/sec 1.00 90.6±0.81µs ? ?/sec arrow_array_reader/FixedLenByteArray(2)/plain encoded, optional, half NULLs 1.16 86.8±1.53µs ? ?/sec 1.00 74.9±0.63µs ? ?/sec arrow_array_reader/FixedLenByteArray(4)/byte_stream_split encoded, optional, half NULLs 1.06 148.4±1.92µs ? ?/sec 1.00 140.4±2.67µs ? ?/sec arrow_array_reader/FixedLenByteArray(4)/plain encoded, optional, half NULLs 1.08 117.0±0.40µs ? ?/sec 1.00 108.0±1.19µs ? ?/sec arrow_array_reader/FixedLenByteArray(8)/byte_stream_split encoded, optional, half NULLs 1.39 241.4±2.93µs ? ?/sec 1.00 173.1±2.77µs ? ?/sec arrow_array_reader/FixedLenByteArray(8)/plain encoded, optional, half NULLs 1.60 174.5±3.44µs ? ?/sec 1.00 109.0±1.27µs ? ?/sec ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
