etseidl commented on PR #6297:
URL: https://github.com/apache/arrow-rs/pull/6297#issuecomment-2315457527

   > > I must have hallucinated last night...turns out copy_from_slice actually 
is a bit faster for the long arrays.
   > 
   > Sorry I didn't follow all the nance of the results here. It seems like you 
have concluded that which approach is faster is a result of what the target 
architecture is?
   
   Sorry, I tend to ramble...I concluded that `copy_from_slice` is the way to 
go since it's better on modern CPUs. I only added the mac results to show I 
hadn't imagined the other approach being faster when I did my initial testing. 
😅 
   
   > 
   > If this is the case, I think my preference would be go with the simplest 
code (e.g. `copy_from_slice`?) otherwise we run the risk of over fitting / over 
optimizing for some specific conditions)
   
   agreed!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to