felipecrv commented on code in PR #43799:
URL: https://github.com/apache/arrow/pull/43799#discussion_r1729952798
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -532,13 +532,13 @@ struct BooleanAnyImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->any = scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
- this->count += scalar.is_valid;
+ this->has_nulls |= !scalar.is_valid;
+ this->any |= scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
Review Comment:
Why the `|`? Isn't that necessary only in `MergeFrom`?
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -532,13 +532,13 @@ struct BooleanAnyImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->any = scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
- this->count += scalar.is_valid;
+ this->has_nulls |= !scalar.is_valid;
+ this->any |= scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
+ this->count += scalar.is_valid * batch.length;
Review Comment:
This one I understand.
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -603,9 +603,9 @@ struct BooleanAllImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->count += scalar.is_valid;
- this->all = !scalar.is_valid || checked_cast<const
BooleanScalar&>(scalar).value;
+ this->has_nulls |= !scalar.is_valid;
+ this->count += scalar.is_valid * batch.length;
+ this->all &= !scalar.is_valid || checked_cast<const
BooleanScalar&>(scalar).value;
return Status::OK();
}
const ArraySpan& data = batch[0].array;
Review Comment:
And my question is why make it `|=` instead of simply `=`?
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -532,13 +532,13 @@ struct BooleanAnyImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->any = scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
- this->count += scalar.is_valid;
+ this->has_nulls |= !scalar.is_valid;
Review Comment:
Is this correct? If the argument is a scalar, isn't it as if the whole batch
was made from repeated values of that scalar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
