mapleFU commented on code in PR #43799:
URL: https://github.com/apache/arrow/pull/43799#discussion_r1730027992
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -532,13 +532,13 @@ struct BooleanAnyImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->any = scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
- this->count += scalar.is_valid;
+ this->has_nulls |= !scalar.is_valid;
+ this->any |= scalar.is_valid && checked_cast<const
BooleanScalar&>(scalar).value;
Review Comment:
See https://github.com/apache/arrow/pull/43799#issuecomment-2308439586
##########
cpp/src/arrow/compute/kernels/aggregate_basic.cc:
##########
@@ -603,9 +603,9 @@ struct BooleanAllImpl : public ScalarAggregator {
}
if (batch[0].is_scalar()) {
const Scalar& scalar = *batch[0].scalar;
- this->has_nulls = !scalar.is_valid;
- this->count += scalar.is_valid;
- this->all = !scalar.is_valid || checked_cast<const
BooleanScalar&>(scalar).value;
+ this->has_nulls |= !scalar.is_valid;
+ this->count += scalar.is_valid * batch.length;
+ this->all &= !scalar.is_valid || checked_cast<const
BooleanScalar&>(scalar).value;
return Status::OK();
}
const ArraySpan& data = batch[0].array;
Review Comment:
The reason is in
https://github.com/apache/arrow/pull/43799#issuecomment-2308439586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
