jorisvandenbossche commented on code in PR #41904:
URL: https://github.com/apache/arrow/pull/41904#discussion_r1731351016
##########
python/pyarrow/tests/test_scalars.py:
##########
@@ -102,6 +100,37 @@ def test_basics(value, ty, klass, pickle_module):
assert wr() is None
[email protected]
+def test_basics_np_required(pickle_module):
+ value, ty, klass = np.float16(1.0), pa.float16(), pa.HalfFloatScalar
+ s = pa.scalar(value, type=ty)
Review Comment:
> I am not sure I understand how the test above is testing `HalfFloatScalar`
if I remove from the parametrization:
> `(np.float16(1.0), pa.float16(), pa.HalfFloatScalar),`
Ah, sorry, I assumed that it would still be in the paramatrization, as we
are also testing the others without a numpy scalar. Is there a reason the test
above cannot use `(1.0, pa.float16(), pa.HalfFloatScalar)` for the
parametrization?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
