mapleFU commented on code in PR #13901:
URL: https://github.com/apache/arrow/pull/13901#discussion_r1733795248
##########
cpp/src/parquet/arrow/schema_internal.cc:
##########
@@ -107,17 +110,22 @@ Result<std::shared_ptr<ArrowType>>
MakeArrowTimestamp(const LogicalType& logical
}
}
-Result<std::shared_ptr<ArrowType>> FromByteArray(const LogicalType&
logical_type) {
+Result<std::shared_ptr<ArrowType>> FromByteArray(
+ const LogicalType& logical_type, const ArrowReaderProperties&
reader_properties) {
switch (logical_type.type()) {
case LogicalType::Type::STRING:
return ::arrow::utf8();
case LogicalType::Type::DECIMAL:
return MakeArrowDecimal(logical_type);
case LogicalType::Type::NONE:
case LogicalType::Type::ENUM:
- case LogicalType::Type::JSON:
case LogicalType::Type::BSON:
return ::arrow::binary();
+ case LogicalType::Type::JSON:
+ if (reader_properties.known_arrow_extensions_enabled()) {
+ return ::arrow::extension::json(::arrow::utf8());
+ }
+ return ::arrow::binary();
Review Comment:
Let's better doing this, thanks! Though I don't so like the idea to use
binary, I think `utf8` is better, in parquet-spec, json is "UTF8 column":
https://github.com/apache/parquet-format/blob/master/src/main/thrift/parquet.thrift#L154
I also want to hear what you think @pitrou @wgtmac
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
