mapleFU commented on code in PR #13901:
URL: https://github.com/apache/arrow/pull/13901#discussion_r1735940704
##########
cpp/src/parquet/arrow/schema_internal.h:
##########
@@ -28,18 +29,19 @@ namespace parquet::arrow {
using ::arrow::Result;
-Result<std::shared_ptr<::arrow::DataType>> FromByteArray(const LogicalType&
logical_type);
+Result<std::shared_ptr<::arrow::DataType>> FromByteArray(const LogicalType&
logical_type,
+ bool
use_known_arrow_extensions);
Result<std::shared_ptr<::arrow::DataType>> FromFLBA(const LogicalType&
logical_type,
int32_t physical_length);
Result<std::shared_ptr<::arrow::DataType>> FromInt32(const LogicalType&
logical_type);
Result<std::shared_ptr<::arrow::DataType>> FromInt64(const LogicalType&
logical_type);
Result<std::shared_ptr<::arrow::DataType>> GetArrowType(
Type::type physical_type, const LogicalType& logical_type, int type_length,
- ::arrow::TimeUnit::type int96_arrow_time_unit = ::arrow::TimeUnit::NANO);
+ const ArrowReaderProperties& reader_properties);
Review Comment:
@pitrou
> It sounds unrelated to this PR.
Maybe yes. Now that we have a lots of different properties to read "string"
out. I think we need some better design on this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
