datbth commented on code in PR #43882:
URL: https://github.com/apache/arrow/pull/43882#discussion_r1735739433
##########
ruby/red-arrow/lib/arrow/decimal128-array.rb:
##########
@@ -18,7 +18,9 @@
module Arrow
class Decimal128Array
def get_value(i)
- BigDecimal(format_value(i))
+ string = format_value(i)
+ string.sub!(".E", ".0E") if string.include?(".E")
Review Comment:
ah sorry for not being clear.
I was thinking in the context of Arrow IPC, where the decimal data is
already [encoded using 2
int64](https://github.com/apache/arrow/blob/main/go/arrow/decimal128/decimal128.go#L49)
(sorry I'm still looking for the C++ implementation).
Though perhaps this code isn't about converting Arrow data into Ruby?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
