datbth commented on code in PR #43882:
URL: https://github.com/apache/arrow/pull/43882#discussion_r1735756794
##########
ruby/red-arrow/lib/arrow/decimal128-array.rb:
##########
@@ -18,7 +18,9 @@
module Arrow
class Decimal128Array
def get_value(i)
- BigDecimal(format_value(i))
+ string = format_value(i)
+ string.sub!(".E", ".0E") if string.include?(".E")
Review Comment:
Correction: It seems Arrow encodes decimal as fixed-size byte array. The
two-complement representation is more of an implementation/runtime thing.
While Ruby BigDecimal cannot be constructed from a byte array anyway (?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
