pitrou commented on code in PR #43766:
URL: https://github.com/apache/arrow/pull/43766#discussion_r1735924602
##########
cpp/src/arrow/filesystem/azurefs_test.cc:
##########
@@ -174,42 +156,32 @@ class AzuriteEnv : public AzureEnvImpl<AzuriteEnv> {
private:
std::unique_ptr<TemporaryDir> temp_dir_;
arrow::internal::PlatformFilename debug_log_path_;
- bp::child server_process_;
+ std::unique_ptr<util::Process> server_process_;
using AzureEnvImpl::AzureEnvImpl;
public:
static const AzureBackend kBackend = AzureBackend::kAzurite;
- ~AzuriteEnv() override {
- server_process_.terminate();
- server_process_.wait();
- }
+ ~AzuriteEnv() override { server_process_ = nullptr; }
Review Comment:
```suggestion
~AzuriteEnv() = default;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
