pitrou commented on code in PR #43766:
URL: https://github.com/apache/arrow/pull/43766#discussion_r1735923995
##########
cpp/cmake_modules/ThirdpartyToolchain.cmake:
##########
@@ -1316,14 +1323,35 @@ if(ARROW_USE_BOOST)
endif()
endforeach()
- if(WIN32 AND CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
- # boost/process/detail/windows/handle_workaround.hpp doesn't work
- # without BOOST_USE_WINDOWS_H with MinGW because MinGW doesn't
- # provide __kernel_entry without winternl.h.
- #
- # See also:
- #
https://github.com/boostorg/process/blob/develop/include/boost/process/detail/windows/handle_workaround.hpp
- target_compile_definitions(Boost::headers INTERFACE
"BOOST_USE_WINDOWS_H=1")
+ if(TARGET Boost::process)
+ # Boost >= 1.86
+ target_compile_definitions(Boost::process INTERFACE
"BOOST_PROCESS_HAVE_V1")
+ target_compile_definitions(Boost::process INTERFACE
"BOOST_PROCESS_HAVE_V2")
+ else()
+ # Boost < 1.86
+ add_library(Boost::process INTERFACE IMPORTED)
+ if(TARGET Boost::filesystem)
+ target_link_libraries(Boost::process INTERFACE Boost::filesystem)
+ endif()
+ if(TARGET Boost::system)
+ target_link_libraries(Boost::process INTERFACE Boost::system)
+ endif()
+ if(TARGET Boost::headers)
+ target_link_libraries(Boost::process INTERFACE Boost::headers)
+ endif()
+ if(Boost_VERSION VERSION_GREATER_EQUAL 1.80)
+ target_compile_definitions(Boost::process INTERFACE
"BOOST_PROCESS_HAVE_V2")
+ # Boost < 1.86 has a bug that
+ # boost::process::v2::process_environment::on_setup() isn't
+ # defined. We need to build Boost Process source to define it.
Review Comment:
Why not simply use v1 on Boost < 1.86?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
