birschick-bq commented on code in PR #2018: URL: https://github.com/apache/arrow-adbc/pull/2018#discussion_r1739225041
########## csharp/src/Drivers/Apache/Spark/README.md: ########## @@ -24,23 +24,26 @@ Properties should be passed in the call to `SparkDriver.Open`, but can also be passed in the call to `AdbcDatabase.Connect`. -| Property | Description | Default | -| :--- | :--- | :--- | -| `adbc.spark.host` | Host name for the data source. Do no include scheme or port number. Example: `sparkserver.region.cloudapp.azure.com` | | -| `adbc.spark.port` | The port number the data source is listen on for new connections. | `443` | -| `adbc.spark.path` | The URI path on the data source server. Example: `sql/protocolv1/o/0123456789123456/01234-0123456-source` | | -| `adbc.spark.token` | For token-based authentication, the token to be authenticated on the data source. Example: `abcdef0123456789` | | -<!-- Add these properties when basic authentication is available. -| `adbc.spark.scheme` | The HTTP or HTTPS scheme to use. Allowed values: `http`, `https`. | `https` - when port is 443 or empty, `http`, otherwise. | -| `auth_type` | An indicator of the intended type of authentication. Allowed values: `basic`, `token`. This property is optional. The authentication type can be inferred from `token`, `username`, and `password`. If a `token` value is provided, token authentication is used. Otherwise, if both `username` and `password` values are provided, basic authentication is used. | | -| `username` | The user name used for basic authentication | | -| `password` | The password for the user name used for basic authentication. | | ---> +| Property | Description | Default | +| :--- | :--- | :--- | +| `adbc.spark.type` | (Required) Indicates the Spark server type. One of `databricks`, `http` (future: `standard`, `hdinsight`) | | +| `adbc.spark.auth_type` | An indicator of the intended type of authentication. Allowed values: `none`, `username_only`,_`basic`, and `token`. This property is optional. The authentication type can be inferred from `token`, `username`, and `password`. If a `token` value is provided, token authentication is used. Otherwise, if both `username` and `password` values are provided, basic authentication is used. | | +| `adbc.spark.host` | Host name for the data source. Do no include scheme or port number. Example: `sparkserver.region.cloudapp.azure.com` | | +| `adbc.spark.port` | The port number the data source is listen on for new connections. | `443` | Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
