birschick-bq commented on code in PR #2018:
URL: https://github.com/apache/arrow-adbc/pull/2018#discussion_r1739229755
##########
csharp/src/Drivers/Apache/Impala/ImpalaConnection.cs:
##########
@@ -26,26 +27,31 @@
namespace Apache.Arrow.Adbc.Drivers.Apache.Impala
{
- public class ImpalaConnection : HiveServer2Connection
+ internal class ImpalaConnection : HiveServer2Connection
{
internal ImpalaConnection(IReadOnlyDictionary<string, string>
properties)
: base(properties)
{
}
- protected override ValueTask<TProtocol> CreateProtocolAsync()
+ protected override Task<TTransport> CreateTransportAsync()
{
- string hostName = properties["HostName"];
+ string hostName = Properties["HostName"];
string? tmp;
int port = 21050; // default?
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
