lidavidm commented on code in PR #43903:
URL: https://github.com/apache/arrow/pull/43903#discussion_r1741306689
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/ByteFunctionHelpers.java:
##########
@@ -295,25 +295,25 @@ private static int memcmp(
}
/** Compute hashCode with the given {@link ArrowBuf} and start/end index. */
- public static int hash(final ArrowBuf buf, long start, long end) {
+ public static long hash(final ArrowBuf buf, long start, long end) {
Review Comment:
Hash code does not strictly need changing and given the number of changes
I'd rather skip it
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/util/HistoricalLog.java:
##########
@@ -32,7 +32,7 @@ public class HistoricalLog {
private final Deque<Event> history = new ArrayDeque<>();
private final String idString; // the formatted id string
- private final int limit; // the limit on the number of events kept
+ private final long limit; // the limit on the number of events kept
Review Comment:
I don't think this needs changing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
