lidavidm commented on code in PR #43903:
URL: https://github.com/apache/arrow/pull/43903#discussion_r1741383328
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/LowCostIdentityHashMap.java:
##########
@@ -317,7 +317,7 @@ public boolean isEmpty() {
* @return the number of mappings in this Map.
*/
public int size() {
- return size;
Review Comment:
No, we don't want to replace everything. (Also I would expect `longSize`)
##########
java/memory/memory-core/src/main/java/org/apache/arrow/memory/LowCostIdentityHashMap.java:
##########
@@ -317,7 +317,7 @@ public boolean isEmpty() {
* @return the number of mappings in this Map.
*/
public int size() {
- return size;
Review Comment:
No, we don't want to replace everything.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
