voidstar69 commented on code in PR #43939:
URL: https://github.com/apache/arrow/pull/43939#discussion_r1742708896
##########
csharp/src/Apache.Arrow/Ipc/ArrowStreamReaderImplementation.cs:
##########
@@ -55,6 +55,9 @@ public override RecordBatch ReadNextRecordBatch()
protected async ValueTask<RecordBatch>
ReadRecordBatchAsync(CancellationToken cancellationToken = default)
{
+ if (BaseStream.Length == 0)
+ return null;
Review Comment:
Is there any downside to checking the length of the stream? This might
require all data to be read from e.g. a network socket, when all we really want
to know here is whether there will be any data at all. Is there a better way to
determine this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
