voidstar69 commented on code in PR #43939:
URL: https://github.com/apache/arrow/pull/43939#discussion_r1767633646
##########
csharp/src/Apache.Arrow/Ipc/ArrowStreamReaderImplementation.cs:
##########
@@ -55,6 +55,9 @@ public override RecordBatch ReadNextRecordBatch()
protected async ValueTask<RecordBatch>
ReadRecordBatchAsync(CancellationToken cancellationToken = default)
{
+ if (BaseStream.Length == 0)
+ return null;
Review Comment:
This code now avoids throwing an exception if zero bytes are read when
reading the schema, instead it simply returns without reading the message.
Is this sufficient? Will a schema always be read before each message is
read? Does something similar need to be implemented for reading from files and
from memory buffers?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
