ianmcook commented on code in PR #43849:
URL: https://github.com/apache/arrow/pull/43849#discussion_r1747545343
##########
docs/source/python/extending_types.rst:
##########
@@ -225,22 +280,22 @@ of the given frequency since 1970.
# attributes need to be set first before calling
# super init (as that calls serialize)
self._freq = freq
- super().__init__(pa.int64(), 'my_package.period')
+ super().__init__(pa.int64(), "my_package.period")
@property
def freq(self):
return self._freq
def __arrow_ext_serialize__(self):
- return "freq={}".format(self.freq).encode()
+ return "freq={self.freq}".encode()
Review Comment:
Please revert the change to this one line. It was correct before but now it
is not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
