ianmcook commented on PR #43849: URL: https://github.com/apache/arrow/pull/43849#issuecomment-2334642940
> The only remaining unaddressed comment from your review about the UUID type in Columnar.rst. However, I actually don't read that one as needing to be replaced _unless_ the intention of _canonical_ extension types is that all Arrow implementations _must_ or _should_ support them. Reading the page on [canonical extensions](https://arrow.apache.org/docs/format/CanonicalExtensions.html) it is unclear to me if arrow implementations _must_ , _should_ , or _may_ support them. If it is _may_, then I think the text of Columnar is actually quite good, though I might modify it as follows: > > > For example, Arrow specifies a canonical extension type that represents a UUID as a `FixedSizeBinary(16)`. Arrow implementations are not required to support canonical extensions, so an implementation that does not support this UUID type will simply interpret it as a `FixedSizeBinary(16)` and pass along the `custom_metadata` in subsequent Arrow protocol messages. I like your suggested modification. I think it's fine that we refer to a canonical extension type there, but I think it's worth saying explicitly that it's a canonical extension type, which is exactly what your modified text does. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
